Skip to content

Conversation

cprecioso
Copy link
Member

@cprecioso cprecioso commented May 20, 2025

Note

This PR goes on top of (#2768). The meat of the new build is there.

Modifies our GitHub actions so that we use the new build workflow. We leave the wasp-ci workflow just for CI checks, and create a new release workflow that gets triggered when we create a tag. This new workflow calls the build and the ci checks workflows, and if both are correct, publishes the new release with the build binaries.

Untitled-2025-05-09-1247 excalidraw

When we start pushing these binaries to our releases, we will have to modify the installer to pick them up.


@cprecioso cprecioso self-assigned this May 20, 2025
@cprecioso cprecioso changed the base branch from main to cprecioso/push-kqnlxsmqzrqq May 20, 2025 15:06
@cprecioso cprecioso changed the title Create releases Publish the new builds to forthcoming releases May 20, 2025
@cprecioso cprecioso marked this pull request as ready for review May 20, 2025 15:25
@cprecioso cprecioso force-pushed the cprecioso/push-kqnlxsmqzrqq branch from 18d1d7e to 5592b5f Compare May 20, 2025 15:28
@cprecioso cprecioso changed the title Publish the new builds to forthcoming releases CI: Publish the new builds to releases from now on May 20, 2025
@infomiho infomiho self-requested a review May 21, 2025 09:58
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cprecioso looking good! Exctied about this same as the other PR. NOthing super major, but left some comments, let's take care of those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this file more? I see you haven't used the new setup-haskell action that you defined, so here we have duplicate logic for dealing with cache and stuff. Or mabye that happens in the later PR so that is why?

We also mention glibc here, talk about how we pick the specific ubuntu version, ... -> we should update that.

Let's do a pass through this whole file and make sure it is updated.

Copy link
Member Author

@cprecioso cprecioso May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is its own can of worms, I started working on it but there are many moving pieces. I deemed it out of scope for this task and was planning on tackling that as part of #2283. Mind if we leave it for then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, but is this really all about speeding up the CI (as 2283 aims for)? It is more about using the new things we added, if I am correct.

Ok let's go about it this way: it makes sense not to try to rework that file right now, but we should at least make it use the new haskell action + whatever was affected by the changes you did in this and that other PR, right? Since those are connected?

If you still feel that is too much for this PR / that other PR, I get that also, but let's make a separate issue for that to track it clearly, as I don't think it falls cleanly under the domain of #2283 .

Copy link

cloudflare-workers-and-pages bot commented May 28, 2025

Deploying wasp-docs-on-main with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8cc772d
Status: ✅  Deploy successful!
Preview URL: https://0e2a6103.wasp-docs-on-main.pages.dev
Branch Preview URL: https://cprecioso-push-nrxmqplymols.wasp-docs-on-main.pages.dev

View logs

@cprecioso
Copy link
Member Author

@Martinsos ready

Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, approved! But do please check that one standing comment before merging (about most likely creating another issue to track further changes in the wasp-ci.yaml).

@cprecioso
Copy link
Member Author

@Martinsos I updated waspc-ci to use the new action, not a lot of work
I will wait to merge this until the previous one is merged (#2768)

Base automatically changed from cprecioso/push-kqnlxsmqzrqq to main May 29, 2025 14:10
@cprecioso cprecioso merged commit 892a735 into main May 29, 2025
2 checks passed
@cprecioso cprecioso deleted the cprecioso/push-nrxmqplymols branch May 29, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Build on older versions of Ubuntu for GLIBC compatibility Solve GLIBC incompatibilty issues Add macos arm64 binary package to our releases

2 participants