-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CI: Publish the new builds to releases from now on #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18d1d7e
to
5592b5f
Compare
…mqzrqq # Conflicts: # waspc/run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cprecioso looking good! Exctied about this same as the other PR. NOthing super major, but left some comments, let's take care of those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this file more? I see you haven't used the new setup-haskell action that you defined, so here we have duplicate logic for dealing with cache and stuff. Or mabye that happens in the later PR so that is why?
We also mention glibc here, talk about how we pick the specific ubuntu version, ... -> we should update that.
Let's do a pass through this whole file and make sure it is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is its own can of worms, I started working on it but there are many moving pieces. I deemed it out of scope for this task and was planning on tackling that as part of #2283. Mind if we leave it for then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, but is this really all about speeding up the CI (as 2283 aims for)? It is more about using the new things we added, if I am correct.
Ok let's go about it this way: it makes sense not to try to rework that file right now, but we should at least make it use the new haskell action + whatever was affected by the changes you did in this and that other PR, right? Since those are connected?
If you still feel that is too much for this PR / that other PR, I get that also, but let's make a separate issue for that to track it clearly, as I don't think it falls cleanly under the domain of #2283 .
Deploying wasp-docs-on-main with
|
Latest commit: |
8cc772d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0e2a6103.wasp-docs-on-main.pages.dev |
Branch Preview URL: | https://cprecioso-push-nrxmqplymols.wasp-docs-on-main.pages.dev |
@Martinsos ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, approved! But do please check that one standing comment before merging (about most likely creating another issue to track further changes in the wasp-ci.yaml).
@Martinsos I updated |
Note
This PR goes on top of (#2768). The meat of the new build is there.
Modifies our GitHub actions so that we use the new build workflow. We leave the
wasp-ci
workflow just for CI checks, and create a new release workflow that gets triggered when we create a tag. This new workflow calls the build and the ci checks workflows, and if both are correct, publishes the new release with the build binaries.When we start pushing these binaries to our releases, we will have to modify the installer to pick them up.