-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add GitHub Action for automatic template release on tag creation #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action for automatic template release on tag creation #511
Conversation
Co-authored-by: cprecioso <511681+cprecioso@users.noreply.github.com>
Co-authored-by: cprecioso <511681+cprecioso@users.noreply.github.com>
template
folder for it, compresses it in a .tar.gz, and uploads it to the github release of that tag.Co-authored-by: cprecioso <511681+cprecioso@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
@infomiho ready |
- name: Create draft release if it doesn't exist | ||
run: | | ||
if ! gh release view "$tag_name"; then | ||
gh release create "$tag_name" --draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why --draft
? If we push a tag, it's a pretty explicit signal that we want to publish it. Maybe we can publish it directly instead of making it a draft first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep you're right, I was thinking that there might be some cases blah blah blah but probably just creating the tag is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one extra comment - feel free to merge after you resolve it. I'm looking forward to testing this!
@infomiho you can see the run at https://github.com/wasp-lang/open-saas/actions/runs/18039032988 and the resulting release at https://github.com/wasp-lang/open-saas/releases/tag/wasp-v0.18-template |
Written by @cprecioso:
wasp new -t saas MyCoolSaasProject
is slow wasp#3147This PR adds a GitHub Action that automatically uploads the compressed
template
folder to the GitHub release when tags matching thewasp-v*-template
pattern are created. You can also run it manually (thanks to theworkflow_dispatch
trigger)Note
Started by a 🤖 robot and finished by a 👨🏻 human