-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use pre-built tarballs for wasp new -t saas
#3196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pre-built tarballs for wasp new -t saas
#3196
Conversation
wasp new -t saas
simpleGhRepoTemplate :: (String, Path' Rel' Dir') -> (String, String) -> StartingInstructionsBuilder -> StarterTemplate | ||
simpleGhRepoTemplate (repoName, tmplPathInRepo) (tmplDisplayName, tmplDescription) buildStartingInstructions = | ||
GhRepoStarterTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to remove the old function, or the linter complained
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/StarterTemplates.hs
Outdated
Show resolved
Hide resolved
|
||
### 🔧 Small improvements | ||
|
||
- Creating a new OpenSaaS project is now much faster (around 20x faster in our testing!). ([#3196](https://github.com/wasp-lang/wasp/pull/3196)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt like boasting a bit 😁
- In `StarterTemplates.hs` file, update git tag to new version of Wasp we are about to release (e.g. `wasp-v0.13.1-template`). | ||
- Ensure that all starter templates are working with this new version of Wasp. | ||
Update Wasp version in their main.wasp files, and update their code as neccessary. Finally, in their repos (for those templates that are on Github), create new git tag that is the same as the new one in `StarterTemplates.hs` (e.g. `wasp-v0.13.1-template`). Now, once new wasp release is out, it will immediately be able to pull the correct and working version of the starter templates, which is why all this needs to happen before we release new wasp version. | ||
Update Wasp version in their main.wasp files, and update their code as neccessary. Finally, in their repos (for those templates that are on Github), create new git tag that is the same as the new one in `StarterTemplates.hs` (e.g. `wasp-v0.13.1-template`), and confirm that the GitHub action correctly ran and uploaded a `template.tar.gz` file. Now, once new wasp release is out, it will immediately be able to pull the correct and working version of the starter templates, which is why all this needs to happen before we release new wasp version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On merging, I will update the release checklist on notion to add this note too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Deploying wasp-docs-on-main with
|
Latest commit: |
6cbcfd0
|
Status: | ✅ Deploy successful! |
Preview URL: | https://43f6a128.wasp-docs-on-main.pages.dev |
Branch Preview URL: | https://cprecioso-3147-wasp-new--t-s.wasp-docs-on-main.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions, looking good overall!
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/StarterTemplates/GhReleaseAsset.hs
Outdated
Show resolved
Hide resolved
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/StarterTemplates/GhReleaseArchive.hs
Outdated
Show resolved
Hide resolved
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/StarterTemplates.hs
Outdated
Show resolved
Hide resolved
@infomiho ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM
Resolves #3147
In wasp-lang/open-saas#511 we made a GitHub action that pre-compresses the OpenSaaS template and allows it to be delivered via the GH CDN.
In this PR, we point
wasp new
to use that asset.On my laptop, it's 20x faster (from ~40s to ~2s)