Skip to content

Fix panic when read/write out of bounds #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jul 1, 2025

Caught at #1553 via Wasmi's execution fuzzer:
https://github.com/wasmi-labs/wasmi/actions/runs/15998303367/job/45126754018?pr=1553

Test case: cargo run -p wasmi_cli <input>

(module
    (memory (;0;) i64 756615 (pagesize 0x1))
    (export "" (memory 0))
    (data (;0;) (i64.const -1) "{")
)

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (8c4dcbe) to head (83dfc39).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/memory/mod.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1554   +/-   ##
=======================================
  Coverage   72.33%   72.34%           
=======================================
  Files         179      179           
  Lines       16318    16320    +2     
=======================================
+ Hits        11803    11806    +3     
+ Misses       4515     4514    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit 88b0f41 into main Jul 1, 2025
18 of 19 checks passed
@Robbepop Robbepop deleted the rf-fix-out-of-bounds-read-write branch July 1, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant