Skip to content

Refactor WasmInteger trait #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025
Merged

Refactor WasmInteger trait #1553

merged 4 commits into from
Jul 1, 2025

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jul 1, 2025

Pulled out from #1512.

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (88b0f41) to head (d1042df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/untyped.rs 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   72.32%   72.34%   +0.02%     
==========================================
  Files         179      179              
  Lines       16320    16328       +8     
==========================================
+ Hits        11803    11813      +10     
+ Misses       4517     4515       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop
Copy link
Member Author

Robbepop commented Jul 1, 2025

Bug fixed in #1554. Ready to merge as soon as #1554 is merged.

@Robbepop Robbepop force-pushed the rf-refactor-wasm-integer-trait branch from d3809da to d1042df Compare July 1, 2025 15:46
@Robbepop Robbepop merged commit bf8e227 into main Jul 1, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-refactor-wasm-integer-trait branch July 1, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant