Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion wagtail_localize/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
Value,
When,
)
from django.db.models.functions import Coalesce
from django.db.models.signals import post_delete, post_save
from django.dispatch import receiver
from django.urls import reverse
Expand Down Expand Up @@ -1139,7 +1140,8 @@ def get_progress(self):
output_field=IntegerField(),
)
).aggregate(
total_segments=Count("pk"), translated_segments=Sum("is_translated_i")
total_segments=Count("pk"),
translated_segments=Coalesce(Sum("is_translated_i"), 0),
)

return aggs["total_segments"], aggs["translated_segments"]
Expand Down
23 changes: 23 additions & 0 deletions wagtail_localize/tests/test_translation_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,18 @@ def test_get_progress_with_translations_in_different_context(self):
progress = self.translation.get_progress()
self.assertEqual(progress, (2, 0))

def test_get_progress_with_no_strings(self):
# Check getting progress when there are no strings to be translated
page = create_test_page(title="Empty page", slug="empty-page")
source, created = TranslationSource.get_or_create_from_instance(page)
translation = Translation.objects.create(
source=source,
target_locale=self.fr_locale,
)

progress = translation.get_progress()
self.assertEqual(progress, (0, 0))


class TestExportPO(TestCase):
def setUp(self):
Expand Down Expand Up @@ -577,6 +589,17 @@ def test_get_status_display_with_translations(self):

self.assertEqual(self.translation.get_status_display(), "Up to date")

def test_get_status_with_no_strings(self):
# Check getting status when there are no strings to be translated
page = create_test_page(title="Empty page", slug="empty-page")
source, created = TranslationSource.get_or_create_from_instance(page)
translation = Translation.objects.create(
source=source,
target_locale=self.fr_locale,
)

self.assertEqual(translation.get_status_display(), "Up to date")


class TestSaveTarget(TestCase):
def setUp(self):
Expand Down