Fix getting progress when there are no strings #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike COUNT, SUM will actually return NULL not 0 when there are no rows, so we need to coalesce to 0 to avoid such cases. This issued caused both the progress and status values to be incorrect for translations. Since `0 != None` an empty page will have its translations marked as "waiting for translations."
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 47 47
Lines 4144 4145 +1
Branches 704 704
=======================================
+ Hits 3857 3858 +1
Misses 173 173
Partials 114 114 ☔ View full report in Codecov by Sentry. |
zerolab
approved these changes
Dec 20, 2024
|
Thank you @alexkiro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike COUNT, SUM will actually return NULL not 0 when there are no rows, so we need to coalesce to 0 to avoid such cases.
This issued caused both the progress and status values to be incorrect for translations. Since
0 != Nonean empty page will have its translations marked as "waiting for translations."