Skip to content

Conversation

@zluda-violet
Copy link
Collaborator

Generate bindings for hipblasLt and make some changes to the bindings for cublasLt. Notably, the hip_type Option is changed to a Vec, so that multiple From implementations (for rocblas_error and hipblasLtError) can be created for cublasError_t.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR creates bindings for the hipblasLt library and makes structural changes to support multiple HIP type conversions. It modifies the existing hip_type field from Option<Path> to a Vec<Path> allowing multiple From implementations for error type conversions, specifically enabling both rocblas_error and hipblasLtError to be converted to cublasError_t.

  • Adds comprehensive hipblasLt bindings with error handling and type conversions
  • Refactors hip_type field to support multiple Hip implementations
  • Fixes type references for cublasComputeType_t in cublasLt modules

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
zluda_bindgen/src/main.rs Core binding generation logic including new hipblasLt generation and hip_type Vec refactoring
ext/hipblaslt-sys/* New hipblasLt library bindings with build configuration and generated source
format/src/format_generated_blaslt.rs Updated display formatting with corrected type references
cuda_types/src/cublaslt.rs Removed duplicate type definitions and cleaned up structure
cuda_types/src/cublas.rs Added hipblasLtError conversion implementation
cuda_macros/src/cublaslt.rs Fixed cublasComputeType_t type references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zluda-violet zluda-violet requested a review from vosen September 16, 2025 22:31
zluda-violet added a commit to zluda-violet/ZLUDA that referenced this pull request Sep 16, 2025
@vosen vosen merged commit 5185138 into vosen:master Sep 16, 2025
6 checks passed
@zluda-violet zluda-violet deleted the bindgen-hipblaslt branch September 16, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants