Skip to content

Conversation

@zluda-violet
Copy link
Collaborator

Depends on #510

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for cuBLASLt functions used by llm.c by implementing comprehensive cuBLAS Lite functionality. It expands the ZLUDA cuBLAS Lite implementation from basic handle management to full matrix multiplication operations including descriptors, preferences, layouts, and algorithm heuristics.

  • Implements core cuBLASLt functions for matrix operations (matmul, descriptors, preferences, layouts)
  • Adds comprehensive type conversions between CUDA and HIP data types and enums
  • Integrates hipblaslt-sys dependency for HIP BLAS Lite backend functionality

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
zluda_common/src/lib.rs Adds type conversions for cuBLASLt data types and enums to HIP equivalents
zluda_common/Cargo.toml Adds hipblaslt-sys dependency
zluda_blaslt/src/lib.rs Expands implemented function list to include matmul operations
zluda_blaslt/src/impl.rs Implements cuBLASLt function handlers with HIP backend calls
zluda_blaslt/Cargo.toml Adds hip_runtime-sys and hipblaslt-sys dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zluda-violet zluda-violet requested a review from vosen September 16, 2025 23:28

from_cuda_object!(Handle);

pub struct MatmulDesc {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole wrapping of hipblasLtMatmulDesc_t, hipblasLtMatmulPreference_t and hipblasLtMatrixLayout_t seems unnecessary to me, if we wrapped those types with some extra data, but as it is now it's better to map them 1:1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, done.

@zluda-violet zluda-violet requested a review from vosen September 17, 2025 17:46
@vosen vosen merged commit 571dad0 into vosen:master Sep 17, 2025
10 of 11 checks passed
@zluda-violet zluda-violet deleted the hipblaslt branch September 17, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants