[V0 Deprecation] Remove Prompt Adapters #20588
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
mgoin
requested review from
hmellor,
DarkLight1337,
robertgshaw2-redhat,
simon-mo,
aarnphm,
WoosukKwon,
njhill,
ywang96,
comaniac,
alexm-redhat,
youkaichao,
tlrmchlsmth,
houseroad and
zhuohan123
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mgoin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a significant cleanup effort focused on deprecating and removing the 'Prompt Adapters' feature from the vLLM project. It streamlines the codebase by eliminating unused components, simplifies the configuration and API, and updates the testing infrastructure to reflect the current state of supported functionalities.
Highlights
- Feature Deprecation: The pull request completely removes all support and usage of 'Prompt Adapters' from the vLLM package, including its core functionalities, testing, and documentation. This is part of a V0 deprecation effort.
- Codebase Cleanup: The
vllm/prompt_adapters/directory and all related files, configurations, and references across the codebase have been deleted or updated to reflect the removal of this feature. This includes configuration classes, CLI arguments, API endpoints, and internal engine logic. - Test Suite Updates: Existing test cases that previously included prompt adapter functionality have been modified to remove any mention or testing of prompt adapters, ensuring the test suite remains relevant and passes with the deprecated feature removed.
- API and Documentation Alignment: The public API documentation and internal configuration structures have been updated to remove
PromptAdapterConfigand any related parameters, providing a cleaner and more accurate representation of the supported features.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated V0 Prompt Adapters feature. The changes are extensive, touching documentation, configuration, tests, and core engine logic across numerous files. The removal appears to be thorough and consistent, with all related code paths, configurations, and tests being correctly updated or deleted. I've reviewed the changes and found no issues. This is a great cleanup effort that improves the maintainability of the codebase.
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
| @@ -52,11 +51,9 @@ async def _embedding_score( | |||
| texts_1: list[str], | |||
| texts_2: list[str], | |||
| request: Union[RerankRequest, ScoreRequest], | |||
| request_id=str, | |||
| request_id: str, | |||
|
This pull request has merge conflicts that must be resolved before it can be |
|
@mgoin Is there any blocker to this PR? Otherwise, I hope we can merge this soon! |
|
I have a lot more high priority work right now. Maybe will get back over the weekend or next week |
|
@mgoin sgtm. No pressure! |
Purpose
This PR is part of V0 deprecation. We will remove all support and usage of prompt adapters from the vLLM package, testing, and documentation.
This means
vllm/prompt_adapters/is completely removed.Test Plan
Rely on green CI since this touches many entrypoints and existing tests
Test Result