[V0 Deprecation] Remove prompt adapter in V1 #1683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
16 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wangxiyuan
reviewed
Jul 14, 2025
| @@ -52,8 +52,6 @@ | |||
| from vllm.multimodal import (MULTIMODAL_REGISTRY, BatchedTensorInputs, | |||
There was a problem hiding this comment.
For V0 code, this file can be removed totally. I think we can remove V0 first. Then remove the related prompt adapter code in V1
shen-shanshan
changed the title
|
Move to #1770, this is don't needed since prompt adapter doesn't exits in v1 code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remove V0 prompt adapter, find more details at vllm-project/vllm#20588.
Does this PR introduce any user-facing change?
How was this patch tested?