[CI/Build] Ensure compatability with Transformers v4.53 #20541
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the transformers library version across the project's testing and continuous integration setup. The core objective is to maintain system compatibility with recent model additions and upcoming features that rely on a newer transformers version, specifically 4.53.
Highlights
- Dependency Update: I've updated the
transformerslibrary version from4.52.4to4.53.1within the project's test environment dependencies. - CI Compatibility: This change ensures compatibility with several newly integrated models and addresses a specific requirement from PR #13754, both of which necessitate
transformersversion4.53or higher.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the transformers dependency to version 4.53.1 to ensure compatibility with new models. The changes in requirements/test.in and requirements/test.txt are correct. However, I've noticed that another requirements file, requirements/nightly_torch_test.txt, still pins transformers to the old version. This should be updated as well to maintain consistency across all CI environments. Please see the detailed comment.
requirements/test.in
Outdated
| @@ -34,7 +34,7 @@ opencv-python-headless >= 4.11.0 # required for video test | |||
| datamodel_code_generator # required for minicpm3 test | |||
| lm-eval[api]==0.4.8 # required for model evaluation test | |||
| mteb[bm25s]>=1.38.11, <2 # required for mteb test | |||
| transformers==4.52.4 | |||
| transformers==4.53.1 | |||
There was a problem hiding this comment.
Thanks for updating the transformers version. To ensure consistency across all CI jobs as intended by this PR, the same update is needed in requirements/nightly_torch_test.txt, which still pins transformers to 4.52.4.
Please update line 32 in requirements/nightly_torch_test.txt:
- transformers==4.52.4
+ transformers==4.53.1This will ensure all tests run against the new version.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
DarkLight1337
added
the
ready
Signed-off-by: Isotr0py <2037008807@qq.com>
mergify
bot
added
multi-modality
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…#20541) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Transformers>=4.53and [Model] Support VLMs with transformers backend #20543 also requires it to work.Test Plan
Test Result
(Optional) Documentation Update