-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[Misc] Automatically tag PRs to add new models #20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances our automated labeling system by introducing a new rule to automatically tag pull requests that add new models with a new-model
label. Concurrently, it cleans up obsolete conditions within the existing multi-modality
labeling workflow, streamlining the repository's automation configuration.
Highlights
- Automated Labeling for New Models: I've added a new Mergify rule named
label-new-model
to automatically apply thenew-model
label to pull requests. This rule is triggered when changes are detected invllm/model_executor/models/
(indicating new model files),vllm/model_executor/models/registry.py
(for model registration),tests/models/registry.py
(for test registration), anddocs/models/supported_models.md
(for documentation updates). - Mergify Configuration Cleanup: I've cleaned up the existing
multi-modality
labeling rule by removing two outdated file path conditions:tests/models/*/audio_language/
andtests/models/*/vision_language/
. These conditions were no longer necessary for the multi-modality label, streamlining the configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Mergify rule to automatically label pull requests that add new models, and it also cleans up an existing rule by removing obsolete file paths. The new rule is well-structured and helps enforce the good practice of updating the model implementation, registries, and documentation simultaneously. I have one suggestion to simplify the YAML configuration for the new rule, making it more concise and easier to maintain.
- and: | ||
- files~=^vllm/model_executor/models/ | ||
- files=vllm/model_executor/models/registry.py | ||
- files=tests/models/registry.py | ||
- files=docs/models/supported_models.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The and:
operator is redundant here. According to the Mergify documentation, conditions in a list are implicitly combined with an AND
operator by default. You can simplify the configuration by removing the and:
block and listing the conditions directly under conditions:
.
- files~=^vllm/model_executor/models/
- files=vllm/model_executor/models/registry.py
- files=tests/models/registry.py
- files=docs/models/supported_models.md
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
It's because that PR missed the update in |
If the tag is for finding the new models that need code review, I prefer to make the condition simpler as new contributors can easily miss some parts. |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update