Skip to content

[Misc] Automatically tag PRs to add new models #20222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Jun 29, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

  • There are lots of PRs to add new models recently, automatically label PRs to add new models support can be helpful to filter them out.
  • Also clean up the dead code for multimodal label workflow

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances our automated labeling system by introducing a new rule to automatically tag pull requests that add new models with a new-model label. Concurrently, it cleans up obsolete conditions within the existing multi-modality labeling workflow, streamlining the repository's automation configuration.

Highlights

  • Automated Labeling for New Models: I've added a new Mergify rule named label-new-model to automatically apply the new-model label to pull requests. This rule is triggered when changes are detected in vllm/model_executor/models/ (indicating new model files), vllm/model_executor/models/registry.py (for model registration), tests/models/registry.py (for test registration), and docs/models/supported_models.md (for documentation updates).
  • Mergify Configuration Cleanup: I've cleaned up the existing multi-modality labeling rule by removing two outdated file path conditions: tests/models/*/audio_language/ and tests/models/*/vision_language/. These conditions were no longer necessary for the multi-modality label, streamlining the configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the ci/build label Jun 29, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Mergify rule to automatically label pull requests that add new models, and it also cleans up an existing rule by removing obsolete file paths. The new rule is well-structured and helps enforce the good practice of updating the model implementation, registries, and documentation simultaneously. I have one suggestion to simplify the YAML configuration for the new rule, making it more concise and easier to maintain.

Comment on lines +70 to +74
- and:
- files~=^vllm/model_executor/models/
- files=vllm/model_executor/models/registry.py
- files=tests/models/registry.py
- files=docs/models/supported_models.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The and: operator is redundant here. According to the Mergify documentation, conditions in a list are implicitly combined with an AND operator by default. You can simplify the configuration by removing the and: block and listing the conditions directly under conditions:.

    - files~=^vllm/model_executor/models/
    - files=vllm/model_executor/models/registry.py
    - files=tests/models/registry.py
    - files=docs/models/supported_models.md

@Isotr0py Isotr0py requested a review from houseroad July 2, 2025 11:52
@Isotr0py Isotr0py changed the title [Misc] Automatically add new-model label for PR to add new models [Misc] Automatically tag PRs to add new models Jul 2, 2025
@vllm-bot vllm-bot merged commit ff5c60f into vllm-project:main Jul 3, 2025
18 checks passed
@Isotr0py Isotr0py deleted the label-new-model branch July 3, 2025 14:11
sfeng33 pushed a commit to sfeng33/vllm that referenced this pull request Jul 6, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
huydhn pushed a commit to huydhn/vllm that referenced this pull request Jul 8, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@heheda12345
Copy link
Collaborator

@Isotr0py #20702 is a new model PR but isn't tagged automatically.

@Isotr0py
Copy link
Collaborator Author

It's because that PR missed the update in docs/models/supported_models.md. The PR should be tagged after adding the new model in documentation. (I intentionally include docs/models/supported_models.md to make sure document updated properly)

@heheda12345
Copy link
Collaborator

If the tag is for finding the new models that need code review, I prefer to make the condition simpler as new contributors can easily miss some parts.

Chen-zexi pushed a commit to Chen-zexi/vllm that referenced this pull request Jul 13, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants