Fix the device error when using ray as vllm-acend backend #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuo97
commented
May 16, 2025
zhuo97
commented
- Remove RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES
- Add lazy init for vllm_ascend_C
zhuo97
force-pushed
the
main
branch
3 times, most recently
from
f085e48 to
f71a8dd
Compare
wangxiyuan
requested changes
May 16, 2025
vllm_ascend/ops/rotary_embedding.py
Outdated
|
|
||
|
|
||
| def custom_rotary_embedding_enabled(query, neox_style, head_size): | ||
| return query.dtype == torch.float16 and neox_style and head_size % 32 == 0 and CUSTOM_OP_ENABLED | ||
| try_register_lib("vllm_ascend.vllm_ascend_C") |
There was a problem hiding this comment.
CI failed. I guess the problem is here. for rotary_embedding test, this func should be called as well.
There was a problem hiding this comment.
Sorry, I forgot to modify test_rotary_embedding.py to use try_register_lib("vllm_ascend.vllm_ascend_C") instead of import vllm_ascend.platform.
zhuo97
force-pushed
the
main
branch
2 times, most recently
from
d4c5e5f to
7d9155d
Compare
|
CI failure has been fixed. Please rebase main again. Thanks. |
wangxiyuan
approved these changes
May 17, 2025
wangxiyuan
requested changes
May 18, 2025
tests/ops/test_rotary_embedding.py
Outdated
| import vllm_ascend.platform # noqa: F401 | ||
| from vllm_ascend.utils import try_register_lib | ||
|
|
||
| try_register_lib("vllm_ascend.vllm_ascend_C") |
There was a problem hiding this comment.
please pass lib_info as well to keep the same as before:
Failed to register custom ops, all custom ops will be disabled
…or vllm_ascend_C Signed-off-by: zhuo97 <1103045176@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.