Fix the device error when using ray as vllm-acend backend #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhuo97
commented
Jun 16, 2025
zhuo97
commented
- Remove RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES
- Add lazy init for vllm_ascend_C
zhuo97
force-pushed
the
v0.9.1-dev
branch
2 times, most recently
from
c50025b to
0065915
Compare
|
LGTM, JFYI, this is a backport of #884 |
…or vllm_ascend_C Signed-off-by: zhuo97 <1103045176@qq.com>
wangxiyuan
approved these changes
Jun 16, 2025
| else: | ||
| try: | ||
| # register custom ops into torch_library here | ||
| import vllm_ascend.vllm_ascend_C # type: ignore # noqa: F401 |
There was a problem hiding this comment.
The import of vllm_ascend_C seems more than this place, can you locate them and wrap them too?
yiz-liu
pushed a commit
to yiz-liu/vllm-ascend
that referenced
this pull request
Jun 17, 2025
…ct#1234) 1. Remove RAY_EXPERIMENTAL_NOSET_ASCEND_RT_VISIBLE_DEVICES 2. Add lazy init for vllm_ascend_C Signed-off-by: zhuo97 <1103045176@qq.com> Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.