[Fix] Enable npu_mrope by environment variables #1231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: #1195 |
|
Pr0Wh1teGivee
force-pushed
the
v0.9.1-dev
branch
3 times, most recently
from
c65f16e to
1cdaf17
Compare
Pr0Wh1teGivee
changed the title
Pr0Wh1teGivee
changed the title
Pr0Wh1teGivee
changed the title
Pr0Wh1teGivee
changed the title
Signed-off-by: Pr0Wh1teGivee <calvin_zhu0210@outlook.com>
Pr0Wh1teGivee
force-pushed
the
v0.9.1-dev
branch
from
1cdaf17 to
610273b
Compare
|
LGTM, please remember to add ut for this |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Even if using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
npu_rotary_embedding will trigger gatherv3's error, enable npu_mrope to solve this issue.
Does this PR introduce any user-facing change?
export VLLM_ASCEND_ENABLE_NPU_MROPE=1to enable npu_mropeHow was this patch tested?
math500 tested in deepseek 671b