[WIP][perf] Replace _npu_rotary_embedding with npu_mrope #1195
+70
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David9857 <985700846@qq.com>
Signed-off-by: David9857 <985700846@qq.com>
Yikun
added
long-term-test
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Yikun
reviewed
Jun 15, 2025
| @@ -64,14 +64,14 @@ def rope_forward_oot( | |||
| # TODO: Remove the contiguous in the future. | |||
| query = query.contiguous().view(query.shape[0], -1) | |||
| key = key.contiguous().view(key.shape[0], -1) | |||
| torch_npu._npu_rotary_embedding( | |||
| query, key = torch_npu.npu_mrope( | |||
There was a problem hiding this comment.
quick question: which torch_npu version supports the npu_mrope operator?
There was a problem hiding this comment.
for graph mode, no release version supports npu_mrope yet
There was a problem hiding this comment.
can you combine #1231 together
David9857
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Replace the original interface(_npu_rotary_embedding) with a new interface(npu_mrope) with better performance.
Does this PR introduce any user-facing change?
NA
How was this patch tested?