Lock click to older version #200
Conversation
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
There was a problem hiding this comment.
@sjmonson can you take a look at these again with the build jobs failing for pre-commit and type checks? I believe it's due to removing the types-click from pre commit config and types-click from the toml. Can we pin those to the latest version before 8.0 rather than removing?
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
@markurtz Fixed linting failures; |
There was a problem hiding this comment.
Pull Request Overview
This PR locks the Click dependency to the last version supporting Python 3.9, removes the now-deprecated types-click, and adjusts some CLI-related code formatting and guard logic.
- Constrain Click to
>=8.0.0,<8.2.0and removetypes-click - Add a
cmd is not Noneguard and updateDefaultCommandFormatterinheritance - Simplify
STRATEGY_PROFILE_CHOICESconstruction and condense a Click decorator
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/guidellm/utils/default_group.py | Guard cmd.name access, insert ctx.arg0 unconditionally, and subclass HelpFormatter |
| src/guidellm/main.py | Change STRATEGY_PROFILE_CHOICES to list(set(...)) and collapse @benchmark.command args |
| pyproject.toml | Lock Click version <8.2.0, remove types-click |
| .pre-commit-config.yaml | Remove types-click hook |
The latest version of click has dropped support for python 3.9 and has additionally introduced breaking interface changes. Until we drop python 3.9, lock to the last supported click version. Additionally types-click has been deprecated since click 8.0.0 so remove it. --------- Co-authored-by: Mark Kurtz <mark.j.kurtz@gmail.com> Signed-off-by: dalthecow <dalcowboiz@gmail.com>
The latest version of click has dropped support for python 3.9 and has additionally introduced breaking interface changes. Until we drop python 3.9, lock to the last supported click version. Additionally types-click has been deprecated since click 8.0.0 so remove it. --------- Co-authored-by: Mark Kurtz <mark.j.kurtz@gmail.com> Signed-off-by: dalthecow <dalcowboiz@gmail.com>
The latest version of click has dropped support for python 3.9 and has additionally introduced breaking interface changes. Until we drop python 3.9, lock to the last supported click version. Additionally types-click has been deprecated since click 8.0.0 so remove it.