Skip to content

The command "guidellm benchmark --help" does not work with latest click version #228

@pliops-daniels

Description

@pliops-daniels

I installed guidellm (from source) on a new python venv (python 3.10).
When I try to run guidellm benchmark --help I get this error:

  File "/.../python3.10/site-packages/click/core.py", line 2212, in make_metavar
    metavar = self.type.get_metavar(param=self, ctx=ctx)
TypeError: Union.get_metavar() got an unexpected keyword argument 'ctx'

This error is related to the click package, after a quick search I found that this issue is related to click version 8.
So I downgraded click to version 7:

pip install click==7.1.2
...
      Successfully uninstalled click-8.2.1
Successfully installed click-7.1.2

And the --help worked with that version, but then a guidellm benchmark command fails:

  File "/.../guidellm/src/guidellm/utils/cli.py", line 23, in set_if_not_default
    if ctx.get_parameter_source(k) != click.core.ParameterSource.DEFAULT:  # type: ignore[attr-defined]
AttributeError: 'Context' object has no attribute 'get_parameter_source'

So simply downgrading click is not a solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions