Skip to content

refactor(trainer): add warning for ignored eval_steps #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(trainer): add warning for ignored eval_steps #3234

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b1db1c
refactor(trainer): add warning for ignored eval_steps
MengAiDev Aug 29, 2025
2aad38f
Update unsloth/trainer.py
MengAiDev Aug 31, 2025
8305fb8
Update unsloth/trainer.py
MengAiDev Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions unsloth/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ class UnslothTrainingArguments(TrainingArguments):
def __init__(self, embedding_learning_rate: float = None, *args, **kwargs):
embedding_learning_rate = embedding_learning_rate
super().__init__(*args, **kwargs)

# Warn if eval_steps is set but eval_strategy is not "steps"
if (hasattr(self, 'eval_steps') and self.eval_steps is not None and
hasattr(self, 'eval_strategy') and self.eval_strategy != "steps"):
import warnings
warnings.warn(
"eval_steps is set but will be ignored because eval_strategy is not set to 'steps'. "
"To use eval_steps, set eval_strategy='steps'.",
UserWarning,
stacklevel=2
)
pass


Expand Down