refactor(trainer): add warning for ignored eval_steps #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MengAiDev
commented
Aug 29, 2025
MengAiDev
commented
- Add a warning message when eval_steps is set but eval_strategy is not 'steps'
- See issue: [Feature] Warning if eval_steps is set, but eval_strategy!="steps" #3177
- Add a warning message when eval_steps is set but eval_strategy is not 'steps'
danielhanchen
requested changes
Aug 30, 2025
Co-authored-by: Daniel Han <danielhanchen@gmail.com>
Co-authored-by: Daniel Han <danielhanchen@gmail.com>
|
@danielhanchen thanks a lot for the change, they make the code more simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.