Online bagger #162
Open
Online bagger #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrzz-hq
requested review from
Carlosdc25
and removed request for
DaniParr and
cbrxyz
Member
|
Hey, thanks! Could you please add some instructions on running this? |
Contributor
Author
|
You can type |
DaniParr
reviewed
Oct 25, 2025
Contributor
DaniParr
left a comment
DaniParr
left a comment
There was a problem hiding this comment.
In general, the code looks good, but when you make future PRs could you provide screenshots / gifs / video links showing how to run your code and what it looks like to run the code.
After you show that it works I can rereview the code!
Contributor
Author
|
I remember we tested this on subjugator during this summer and it worked well. Carlos said he would approve the pull request but he hasn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first C++ version of the online bagger has been completed and is ready for testing on a vechicle. When would be a good time to test it?