-
Notifications
You must be signed in to change notification settings - Fork 4
Break installation defaults out as their own structure. #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f6f448
to
9400618
Compare
23ae04a
to
3388101
Compare
6b7936f
to
24e8183
Compare
24e8183
to
f4198e0
Compare
The restructure looks good and I was just about to merge when I noticed the py2 unit tests failing as described above. Should we move the |
So I considered that but actually I'd lean towards not yet - I think the "how we might wan this to be" story is still evolving and it's less churn to leave them there and follow-up once we have clearer picture (some extra context here: #83 (comment)). |
Not sure if this overlaps with your recent answer, but while experimenting a bit with that move into |
cb3da6a
to
6b2f337
Compare
Hah yep. The big reason I leaned towards SimpleNamespace as opposed to dict is such that the defaults could be consumed as attributes, but there is so little to SimpleNamespace that I just the handful lines necessary to compat. |
6b2f337
to
bab43cd
Compare
Add tests that assert the consistency of the options that are accepted by the generateconfs command line with the internal library function. Additionally assert that the library routine itself matches the defaults structure thus making the _structure_ the definitive source of truth. Doing so highlighted the following missing command line options which are added as of this commit: --seafile_secret --seafile_ccnetid
bab43cd
to
ff29485
Compare
Add tests that assert the consistency of options accepted by the
generateconfs command line against the internal library function.
Additionally assert that the library routine itself matches the defaults
structure thus making the structure the definitive source of truth.
Doing so highlighted the following missing command line options which
are added as of this commit:
--seafile_secret
--seafile_ccnetid