Directly test the prepared user_dict put together by generateconfs. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albu-diku
force-pushed
the
test/installation-user_dict
branch
from
50503b4 to
08c432f
Compare
albu-diku
changed the base branch from
edge
to
refactor/split-out-install-defaults
|
Looks fine. I suppose the choice of json is for platform independence and that's good, but is it on purpose that the json file write addition is included in |
jonasbardino
approved these changes
Jul 22, 2024
albu-diku
force-pushed
the
refactor/split-out-install-defaults
branch
3 times, most recently
from
cb3da6a to
6b2f337
Compare
albu-diku
force-pushed
the
test/installation-user_dict
branch
from
08c432f to
6afe736
Compare
Closed
Add tests that assert the consistency of the options that are accepted by the generateconfs command line with the internal library function. Additionally assert that the library routine itself matches the defaults structure thus making the _structure_ the definitive source of truth. Doing so highlighted the following missing command line options which are added as of this commit: --seafile_secret --seafile_ccnetid
albu-diku
force-pushed
the
refactor/split-out-install-defaults
branch
from
6b2f337 to
bab43cd
Compare
albu-diku
force-pushed
the
test/installation-user_dict
branch
from
6afe736 to
1d0e47b
Compare
albu-diku
force-pushed
the
refactor/split-out-install-defaults
branch
from
bab43cd to
ff29485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #83