(Background sync) Change logic from current week to now #3147
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe changes update the time window logic for Google Calendar event synchronization and related background sync range checks, shifting the reference from the start of the current week to the current moment. Additionally, type definitions in Supabase are reformatted for consistent property ordering, without altering logic or exported function signatures. Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/trigger/google-calendar-sync.tsOops! Something went wrong! :( ESLint: 9.29.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@typescript-eslint/parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (11)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
=======================================
Coverage 0.79% 0.80%
=======================================
Files 2569 2569
Lines 328129 328124 -5
Branches 3071 3071
=======================================
Hits 2625 2625
+ Misses 323311 323306 -5
Partials 2193 2193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @DennieDan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the background Google Calendar synchronization mechanism by shifting its time reference from the beginning of the current week to the immediate present, ensuring a more dynamic and up-to-date sync window. It also includes a significant number of reordered type definitions, likely from an automated process, which do not impact runtime behavior.
Highlights
- Google Calendar Sync Logic Update: The background Google Calendar synchronization process has been updated to use the current time (
now) as its reference point for determining the sync window. Previously, it used the start of the current week. This change ensures the sync always looks forward from the immediate present for the definedBACKGROUND_SYNC_RANGE. - Date Range Utility Function Alignment: The
isWithinBackgroundSyncRangeutility function incalendar-sync-coordination.tshas been modified to align with the new sync logic. It now calculates the relevant 4-week range from the current time (dayjs()) instead of the start of the current week, and its JSDoc comments have been updated to reflect this change. - Supabase Type Definition Reordering: Numerous type definitions within
packages/types/src/supabase.tshave been reordered. These changes are purely structural within the type definitions (reordering of properties inArgsandReturnsobjects for various database functions) and do not introduce any functional changes to the application. This is likely a result of an automated type generation process.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The code changes update the background sync logic to use the current time instead of the start of the current week. Additionally, the order of arguments in several function definitions in packages/types/src/supabase.ts has been modified. It's crucial to ensure that all existing calls to these functions are updated to reflect the new argument order to avoid unexpected behavior.
| p_user_id: string; | ||
| p_session_data?: Json; | ||
| p_expiry_seconds?: number; | ||
| p_target_app: string; | ||
| p_origin_app: string; | ||
| p_target_app: string; | ||
| p_expiry_seconds?: number; | ||
| p_session_data?: Json; |
There was a problem hiding this comment.
Reordering the arguments might affect existing calls to this function. Ensure that all usages are updated accordingly.
|
{
p_user_id: string;
p_origin_app: string;
p_target_app: string;
p_expiry_seconds?: number;
p_session_data?: Json;
};| const timeMax = startOfCurrentWeek | ||
| .add(BACKGROUND_SYNC_RANGE, 'day') | ||
| .toDate(); | ||
| const now = dayjs(); |
There was a problem hiding this comment.
Consider using dayjs.utc() to ensure consistency across different timezones.
| const now = dayjs(); | |
| const now = dayjs.utc(); |
Summary by CodeRabbit