Skip to content

test: Fix L0_simple_lib--base #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

test: Fix L0_simple_lib--base #8431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/simple.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2020-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// Copyright 2020-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -876,6 +876,10 @@ main(int argc, char** argv)
FAIL_IF_ERR(
TRITONSERVER_InferenceResponseDelete(completed_response),
"deleting inference response");

// We need to make sure that the previous request was released before
// reusing it.
request_release_future.get();
}

// The TRITONSERVER_InferenceRequest object can be reused for
Expand Down Expand Up @@ -906,10 +910,6 @@ main(int argc, char** argv)
InferResponseComplete, reinterpret_cast<void*>(p)),
"setting response callback");

// We need to make sure that the previous request was released before
// reusing it.
request_release_future.get();

// Register a new promise for the request callback barrier.
barrier = std::make_unique<std::promise<void>>();
request_release_future = barrier->get_future();
Expand All @@ -936,6 +936,10 @@ main(int argc, char** argv)
FAIL_IF_ERR(
TRITONSERVER_InferenceResponseDelete(completed_response),
"deleting inference response");

// We need to make sure that the previous request was released before
// reusing it.
request_release_future.get();
}

// There are other TRITONSERVER_InferenceRequest APIs that allow
Expand Down Expand Up @@ -967,7 +971,7 @@ main(int argc, char** argv)

// Register a new promise for the request callback barrier.
barrier = std::make_unique<std::promise<void>>();
request_release_future.get();
request_release_future = barrier->get_future();

FAIL_IF_ERR(
TRITONSERVER_InferenceRequestSetReleaseCallback(
Expand All @@ -993,6 +997,10 @@ main(int argc, char** argv)
FAIL_IF_ERR(
TRITONSERVER_InferenceResponseDelete(completed_response),
"deleting inference response");

// Make sure the request is released before deleting it. If not, release
// callback will segfault after barrier is destructed.
request_release_future.get();
}

FAIL_IF_ERR(
Expand Down
Loading