Skip to content

test: Fix L0_simple_lib--base #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

test: Fix L0_simple_lib--base #8431

merged 1 commit into from
Oct 2, 2025

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Oct 1, 2025 •
edited
Loading

What does the PR do?

Fix race condition. The barrier object is destructed before access in request release callbacks, leading to segfault.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/core#452

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:
    35850970

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh yinggeh self-assigned this Oct 1, 2025
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Oct 1, 2025
whoisj
whoisj reviewed Oct 1, 2025
View reviewed changes
Copy link
Contributor

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct-ish, but I left a question (repeated 3 times) for you.

@yinggeh yinggeh requested review from pskiran1 and whoisj October 1, 2025 19:19
@yinggeh yinggeh changed the title test: Fix 0_simple_lib test: Fix L0_simple_lib--base Oct 2, 2025
@yinggeh yinggeh merged commit 280a6dc into main Oct 2, 2025
3 checks passed
@yinggeh yinggeh deleted the yinggeh/tri-85-2509-ci-failure-l0_simple_lib-base branch October 2, 2025 15:57
yinggeh added a commit that referenced this pull request Oct 2, 2025
@yinggeh
test: Fix L0_simple_lib--base (#8431)
e7a7963
mc-nv pushed a commit that referenced this pull request Oct 2, 2025
@yinggeh
test: Fix L0_simple_lib--base (#8431) (#8436)
5dc43cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whoisj whoisj whoisj approved these changes

@pskiran1 pskiran1 pskiran1 approved these changes

Assignees

@yinggeh yinggeh

Labels

PR: test Adding missing tests or correcting existing test

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yinggeh @whoisj @pskiran1