Skip to content

fix: Avoid invoking internal release callback multiple times when reusing request object #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

fix: Avoid invoking internal release callback multiple times when reusing request object #452

merged 1 commit into from
Oct 2, 2025

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Oct 1, 2025 •
edited
Loading

Avoid adding duplicated internal release callback and invoking multiple times when reusing request object
Add a boolean flag to indicate internal release callbacks.

@yinggeh yinggeh self-assigned this Oct 1, 2025
@yinggeh yinggeh added the bug Something isn't working label Oct 1, 2025
@yinggeh yinggeh mentioned this pull request Oct 1, 2025
Merged
11 tasks
@yinggeh yinggeh requested review from pskiran1 and whoisj October 1, 2025 19:19
pskiran1
pskiran1 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@pskiran1 pskiran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yinggeh yinggeh merged commit 9f6c3ca into main Oct 2, 2025
1 check passed
yinggeh added a commit that referenced this pull request Oct 2, 2025
@yinggeh
fix: Evict inference request internal release callback after invoking (…
92f2b1c 
…#452)
yinggeh added a commit that referenced this pull request Oct 2, 2025
@yinggeh
fix: Minor fix to "fix: Evict inference request internal release call…
a4ed606 
…back after invoking (#452)"
yinggeh added a commit that referenced this pull request Oct 2, 2025
@yinggeh
fix: Minor fix to "fix: Evict inference request internal release call…
d2057d4 
…back after invoking (#452)"
yinggeh added a commit that referenced this pull request Oct 2, 2025
@yinggeh
fix: Evict inference request internal release callback after invoking (…
1d845ec 
…#452)
yinggeh added a commit that referenced this pull request Oct 2, 2025
@yinggeh
fix: Minor fix to "fix: Evict inference request internal release call…
df6df32 
…back after invoking (#452)"
mc-nv pushed a commit that referenced this pull request Oct 2, 2025
@yinggeh
fix: Evict inference request internal release callback after invoking (…
564a324 
…#452) (#453)

* fix: Evict inference request internal release callback after invoking (#452)

* fix: Minor fix to "fix: Evict inference request internal release callback after invoking (#452)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whoisj whoisj whoisj approved these changes

@pskiran1 pskiran1 pskiran1 approved these changes

Assignees

@yinggeh yinggeh

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yinggeh @whoisj @pskiran1