[SDK] Feature: Update PayEmbed to use new widgets #7394

gregfromstl · 2025-06-20T19:35:23Z

PR-Codex overview

This PR focuses on updating the PayEmbed UI, enhancing the payment options, and improving the way chains are defined in the RightSection component. It also refines type handling for amount in various components.

Detailed summary

Updated amount handling in UniversalBridgeEmbed to allow optional amount.
Added defineChain for better chain management in RightSection.
Improved PayEmbed to support different payment modes: fund_wallet, direct_payment, and transaction.
Introduced BuyWidget, CheckoutWidget, and TransactionWidget for enhanced UI.
Removed unused ExecutingTxScreen from PayEmbed.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Added support for a new blockchain network in the sign-in button's chain selection.
Bug Fixes
- Improved handling of payment widget modes, ensuring the correct widget is displayed for each payment scenario.
- Enhanced reliability by making the amount input optional in the bridge embed component and removing default fallback values.
Refactor
- Simplified the payment widget's internal logic for more predictable behavior.

linear · 2025-06-20T19:35:26Z

TOOL-4848 Update to use BuyWidget and improve PayEmbed performance

changeset-bot · 2025-06-20T19:35:27Z

🦋 Changeset detected

Latest commit: 57134fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
thirdweb	Minor
@thirdweb-dev/wagmi-adapter	Patch
nebula	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-06-20T19:35:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 7:56pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 7:56pm
nebula	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 7:56pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 7:56pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 7:56pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 7:56pm

coderabbitai · 2025-06-20T19:35:30Z

Walkthrough

The UniversalBridgeEmbed component's amount prop is now optional, and its behavior for passing the prefillBuy property to PayEmbed is conditional on the presence of chainId and token. The PayEmbed component was refactored to directly render specific widgets based on the mode property, removing previous internal screen state logic. A new chain was added to the ConnectButton in the playground.

Changes

File(s)	Change Summary
apps/dashboard/src/app/bridge/components/client/UniversalBridgeEmbed.tsx	Made `amount` prop optional; conditionally sets `prefillBuy` in `payOptions` based on `chainId` and `token`.
apps/dashboard/src/app/bridge/page.tsx	Removed fallback default value for `amount` prop when passing to `UniversalBridgeEmbed`.
packages/thirdweb/src/react/web/ui/PayEmbed.tsx	Refactored to render `BuyWidget`, `CheckoutWidget`, or `TransactionWidget` directly based on `payOptions.mode`.
apps/playground-web/src/app/connect/sign-in/button/RightSection.tsx	Added a new chain using `defineChain(578)` to the `ConnectButton`'s `chains` prop.

Sequence Diagram(s)

sequenceDiagram
    participant UniversalBridgeEmbed
    participant PayEmbed
    participant BuyWidget
    participant CheckoutWidget
    participant TransactionWidget

    UniversalBridgeEmbed->>PayEmbed: Render with payOptions (mode, prefillBuy)
    alt mode == "fund_wallet" and prefillBuy exists
        PayEmbed->>BuyWidget: Render with chain, amount, tokenAddress
    else mode == "direct_payment"
        PayEmbed->>CheckoutWidget: Render with chain, tokenAddress, amount, sellerAddress
    else mode == "transaction"
        PayEmbed->>TransactionWidget: Render with transaction data and metadata
    end

Possibly related PRs

thirdweb-dev/js#7165: Both PRs directly modify UniversalBridgeEmbed's props and internal logic.
thirdweb-dev/js#7176: Both PRs update UniversalBridgeEmbed's props and handling of token and amount, indicating overlapping changes to the same component.

Suggested reviewers

joaquim-verges
jnsdls

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41bb01e and 57134fd.

📒 Files selected for processing (1)

.changeset/wide-books-ring.md (1 hunks)

✅ Files skipped from review due to trivial changes (1)

.changeset/wide-books-ring.md

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Size
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Unit Tests
GitHub Check: Build Packages
GitHub Check: Analyze (javascript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graphite-app · 2025-06-20T19:35:31Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2025-06-20T19:41:43Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.53 KB (0%)	1.3 s (0%)	234 ms (+207.98% 🔺)	1.5 s
thirdweb (cjs)	350.55 KB (0%)	7.1 s (0%)	626 ms (+7.6% 🔺)	7.7 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	115 ms (+2705.41% 🔺)	229 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	92 ms (+6530.92% 🔺)	102 ms
thirdweb/react (minimal + tree-shaking)	19.59 KB (0%)	392 ms (0%)	94 ms (+567.01% 🔺)	486 ms

codecov · 2025-06-20T19:42:24Z

Codecov Report

Attention: Patch coverage is 9.09091% with 40 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (492c6d0) to head (57134fd).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/thirdweb/src/react/web/ui/PayEmbed.tsx	9.09%	40 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7394      +/-   ##
==========================================
- Coverage   52.44%   52.20%   -0.24%     
==========================================
  Files         941      945       +4     
  Lines       63199    63578     +379     
  Branches     4226     4229       +3     
==========================================
+ Hits        33142    33192      +50     
- Misses      29950    30279     +329     
  Partials      107      107

Flag	Coverage Δ
packages	`52.20% <9.09%> (-0.24%)`	⬇️

Files with missing lines	Coverage Δ
packages/thirdweb/src/react/web/ui/PayEmbed.tsx	`40.14% <9.09%> (-5.95%)`	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gregfromstl added 2 commits June 20, 2025 12:17

feat: use BuyWidget in bridge page

6177e11

feat: use new components in PayEmbed

3de47ce

gregfromstl requested review from a team as code owners June 20, 2025 19:35

github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Jun 20, 2025

github-actions bot assigned gregfromstl Jun 20, 2025

vercel bot deployed to Preview – wallet-ui June 20, 2025 19:35 View deployment

vercel bot deployed to Preview – login June 20, 2025 19:35 View deployment

vercel bot deployed to Preview – nebula June 20, 2025 19:36 View deployment

lint

41bb01e

vercel bot deployed to Preview – login June 20, 2025 19:38 View deployment

vercel bot deployed to Preview – nebula June 20, 2025 19:39 View deployment

vercel bot deployed to Preview – thirdweb_playground June 20, 2025 19:40 View deployment

vercel bot deployed to Preview – wallet-ui June 20, 2025 19:40 View deployment

changeset

57134fd

vercel bot deployed to Preview – thirdweb_playground June 20, 2025 19:49 View deployment

vercel bot deployed to Preview – wallet-ui June 20, 2025 19:49 View deployment

gregfromstl merged commit 9c420c0 into main Jun 20, 2025
16 of 21 checks passed

gregfromstl deleted the greg/tool-4848-update-to-use-buywidget-and-improve-payembed-performance branch June 20, 2025 19:50

vercel bot deployed to Preview – nebula June 20, 2025 19:50 View deployment

vercel bot deployed to Preview – login June 20, 2025 19:50 View deployment

joaquim-verges mentioned this pull request Jun 20, 2025

Version Packages #7372

Closed

vercel bot deployed to Preview – docs-v2 June 20, 2025 19:55 View deployment

vercel bot deployed to Preview – thirdweb-www June 20, 2025 19:56 View deployment

joaquim-verges mentioned this pull request Jun 21, 2025

Version Packages #7404

Merged

This was referenced Jun 24, 2025

Feature: UB Widget Tracking and Docs #7426

Merged

[TOOL-4898] Dashboard: Replace PayEmbed with BuyWidget in asset page, add tracking #7459

Merged

[SDK] Add enableCard prop to control fiat payment visibility #7465

Merged

coderabbitai bot mentioned this pull request Jul 2, 2025

Pass purchaseData prop to payment components #7507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Feature: Update PayEmbed to use new widgets #7394

[SDK] Feature: Update PayEmbed to use new widgets #7394

Uh oh!

gregfromstl commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

linear bot commented Jun 20, 2025

Uh oh!

changeset-bot bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

graphite-app bot commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[SDK] Feature: Update PayEmbed to use new widgets #7394

[SDK] Feature: Update PayEmbed to use new widgets #7394

Uh oh!

Conversation

gregfromstl commented Jun 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

linear bot commented Jun 20, 2025

Uh oh!

changeset-bot bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

graphite-app bot commented Jun 20, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

gregfromstl commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jun 20, 2025 •

edited

Loading

vercel bot commented Jun 20, 2025 •

edited

Loading

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 20, 2025 •

edited

Loading

codecov bot commented Jun 20, 2025 •

edited

Loading