Skip to content

Pass purchaseData prop to payment components #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jul 2, 2025

Added the purchaseData prop from payOptions to the payment components in PayEmbed. This enables passing additional purchase-related data to the payment flows.


PR-Codex overview

This PR focuses on fixing the propagation of purchaseData in the PayEmbed component to accommodate new widget implementations.

Detailed summary

  • Updated the PayEmbed component to include purchaseData from props.payOptions.
  • Ensured purchaseData is typed as Record<string, unknown> | undefined.
  • Made changes in multiple locations within the PayEmbed function to handle purchaseData.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Enhanced payment widgets to include additional purchase information during checkout and transactions.

Added the purchaseData prop from payOptions to the payment components in PayEmbed. This enables passing additional purchase-related data to the payment flows.
@0xFirekeeper 0xFirekeeper requested review from a team as code owners July 2, 2025 16:28
Copy link

changeset-bot bot commented Jul 2, 2025

🦋 Changeset detected

Latest commit: e490364

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 4:54pm
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 4:54pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 4:54pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 4:54pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 4:54pm

Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

"""

Walkthrough

The PayEmbed component was modified to forward a purchaseData prop, sourced from props.payOptions, to its child components (BuyWidget, CheckoutWidget, and TransactionWidget) within their respective conditional render branches. No other logic, control flow, or exported/public entity signatures were changed.

Changes

File(s) Change Summary
packages/thirdweb/src/react/web/ui/PayEmbed.tsx Added passing of purchaseData prop from props.payOptions to BuyWidget, CheckoutWidget, and TransactionWidget in their respective render branches. No other logic or interface changes.

Possibly related PRs

Suggested reviewers

  • joaquim-verges
    """

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d28e004 and e490364.

📒 Files selected for processing (2)
  • .changeset/short-foxes-decide.md (1 hunks)
  • packages/thirdweb/src/react/web/ui/PayEmbed.tsx (3 hunks)
✅ Files skipped from review due to trivial changes (2)
  • .changeset/short-foxes-decide.md
  • packages/thirdweb/src/react/web/ui/PayEmbed.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jul 2, 2025
Copy link
Contributor

graphite-app bot commented Jul 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Explicitly casts the purchaseData prop to Record<string, unknown> | undefined in multiple locations within PayEmbed.tsx to ensure correct typing and prevent potential type errors.
@0xFirekeeper 0xFirekeeper added the hotfix This pull request should be prioritized in the merge queue. label Jul 2, 2025
Copy link
Member Author

0xFirekeeper commented Jul 2, 2025

Merge activity

  • Jul 2, 4:39 PM UTC: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 2, 4:40 PM UTC: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 2, 4:53 PM UTC: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 299 ms (+156.36% 🔺) 1.6 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 1.1 s (+13.09% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 123 ms (+1534.14% 🔺) 237 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 60 ms (+1247.84% 🔺) 70 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 140 ms (+520.72% 🔺) 531 ms

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.96%. Comparing base (7ab8808) to head (e490364).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7507      +/-   ##
==========================================
- Coverage   51.96%   51.96%   -0.01%     
==========================================
  Files         952      952              
  Lines       64221    64227       +6     
  Branches     4238     4238              
==========================================
+ Hits        33375    33377       +2     
- Misses      30739    30743       +4     
  Partials      107      107              
Flag Coverage Δ
packages 51.96% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 34.37% <0.00%> (-1.34%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jakeloo jakeloo merged commit fd967ce into main Jul 2, 2025
21 of 24 checks passed
@jakeloo jakeloo deleted the firekeeper/fix-purchasedata branch July 2, 2025 16:49
@joaquim-verges joaquim-verges mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This pull request should be prioritized in the merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants