Skip to content

Update to colcon-action v13 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong
Copy link
Contributor Author

@johnwason @marip8 Do you have any ideas why this is not working when switching to the latest version for colcon-action? It looks like it is looking locally for the ./linux/action.yml instead of the one from the colcon-action.yml

@johnwason
Copy link
Contributor

@Levi-Armstrong you need to use ${{ github.action_path }} as the root path for the sub actions. Right now it is looking for the sub actions in the workspace. So instead of uses: ./windows use uses: ${{ github.action_path }}/windows.

@Levi-Armstrong
Copy link
Contributor Author

That does not seem to work

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (4eff996) to head (6648d22).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files           2        2           
  Lines         182      182           
=======================================
  Hits          179      179           
  Misses          3        3           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Levi-Armstrong
Copy link
Contributor Author

@johnwason and @marip8 I found an action that provides an action which works around the issue. Though should we just remove the top level action and require user to just specify the sub directory if that is possible?
tesseract-robotics/colcon-action/linux@v13
tesseract-robotics/colcon-action/macos@v13
tesseract-robotics/colcon-action/windows@v13

@johnwason
Copy link
Contributor

@Levi-Armstrong there are times when we may have the same job with different OS in a matrix so I do not recommend using separate actions.

@Levi-Armstrong Levi-Armstrong merged commit 36499f5 into tesseract-robotics:main Jul 9, 2025
9 of 14 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/update-colcon-action branch July 9, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants