Skip to content

Improve actions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 8, 2025
Merged

Conversation

johnwason
Copy link
Contributor

@johnwason johnwason commented Jul 7, 2025

This PR improves the GitHub actions workflows:

  • Fix Windows action and use colcon-action
  • Add MacOS action

This is a draft PR and requires the following changes:

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (6de7d59) to head (5d9820b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files           2        2           
  Lines         182      182           
=======================================
  Hits          179      179           
  Misses          3        3           
Files with missing lines Coverage Δ
src/utils.cpp 97.36% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnwason
Copy link
Contributor Author

These tests in plugin_loader_unit.cpp are failing on MacOS action because the library is being found:

{
    PluginLoader plugin_loader;
    plugin_loader.search_system_folders = false;
    plugin_loader.search_paths.insert("does_not_exist");
    plugin_loader.search_libraries.insert(std::string(PLUGINS));

    EXPECT_FALSE(plugin_loader.isPluginAvailable("plugin"));
    // Behavior change: used to return nullptr but now throws exception
    // NOLINTNEXTLINE(cppcoreguidelines-avoid-goto)
    EXPECT_ANY_THROW(plugin_loader.createInstance<TestPluginBase>("plugin"));
  }

I have traced the call to boost dll and the path is being passed with the does_not_exist prefix, but the library is still being loaded. This failure does not happen on my local machine. I don't have an explanation.

@Levi-Armstrong Levi-Armstrong marked this pull request as ready for review July 8, 2025 18:52
@Levi-Armstrong Levi-Armstrong merged commit 4eff996 into tesseract-robotics:main Jul 8, 2025
9 checks passed
@johnwason johnwason mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants