-
Notifications
You must be signed in to change notification settings - Fork 4
Improve actions #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve actions #27
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 2 2
Lines 182 182
=======================================
Hits 179 179
Misses 3 3
🚀 New features to boost your workflow:
|
These tests in {
PluginLoader plugin_loader;
plugin_loader.search_system_folders = false;
plugin_loader.search_paths.insert("does_not_exist");
plugin_loader.search_libraries.insert(std::string(PLUGINS));
EXPECT_FALSE(plugin_loader.isPluginAvailable("plugin"));
// Behavior change: used to return nullptr but now throws exception
// NOLINTNEXTLINE(cppcoreguidelines-avoid-goto)
EXPECT_ANY_THROW(plugin_loader.createInstance<TestPluginBase>("plugin"));
} I have traced the call to boost dll and the path is being passed with the does_not_exist prefix, but the library is still being loaded. This failure does not happen on my local machine. I don't have an explanation. |
This PR improves the GitHub actions workflows:
This is a draft PR and requires the following changes:
Rebase after merging Fix missing algorithm.h header in plugin_loader.hpp #26