Skip to content

feat(harbor-scanner-sysdig-deploy): Allow usage of an existing secret for cliScanning #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2025

Conversation

dark-vex
Copy link
Collaborator

What this PR does / why we need it:

This allows the jobs spun up when cliScanning is enabled to use a secret with a different name than 'harbor-scanner-sysdig-secure.fullname'. This is useful if there is a secret defined with the same name for a different purpose.

This is a cherry-pick of PR:
#2247

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@dark-vex dark-vex requested a review from mavimo May 16, 2025 13:23
@dark-vex dark-vex enabled auto-merge (squash) May 16, 2025 13:55
@dark-vex dark-vex merged commit 7855622 into main May 16, 2025
4 checks passed
@dark-vex dark-vex deleted the ddl/harbor-scanner branch May 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants