feat(harbor-scanner-sysdig-deploy): Allow cliScanning SECRET_NAME to be Configurable #2247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sthwang-metal. Thanks for your PR. After inspecting your changes someone with write access to this repo needs |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests
sthwang-metal
changed the title
sthwang-metal
force-pushed
the
make-cliScanning-secret-configurable
branch
2 times, most recently
from
0f5bac8 to
d82756d
Compare
Signed-off-by: Stephen Hwang <126002920+sthwang-metal@users.noreply.github.com>
mavimo
force-pushed
the
make-cliScanning-secret-configurable
branch
from
abcbe94 to
7dd3549
Compare
|
Hey @sthwang-metal thanks for your contribution! I added some test to cover the use case you added and made few minor changes, once test are executed i'll approve 🙌 |
mavimo
approved these changes
May 15, 2025
5 tasks
|
Hey @sthwang-metal we had an issue in merging this PR so I've created a new one (#2254) by cherry-pick your's and Marco's commits. I close this one, thanks a lot for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Hwang 126002920+sthwang-metal@users.noreply.github.com
What this PR does / why we need it:
This allows the jobs spun up when cliScanning is enabled to use a secret with a different name than 'harbor-scanner-sysdig-secure.fullname'. This is useful if there is a secret defined with the same name for a different purpose.
Checklist
feat(agent,node-analyzer,sysdig-deploy):)