Skip to content

Remove some remnants of the C++ section discovery code that we no longer need. #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 13, 2025
Merged

Remove some remnants of the C++ section discovery code that we no longer need. #905

merged 8 commits into from
Jan 13, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 11, 2025 •
edited
Loading

This PR removes additional C++ section discovery code that is no longer needed.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Remove some remnants of the C++ section discovery code that we no lon…
80be5a0 
…ger need.

This PR removes additional C++ section discovery code that is no longer needed.
@grynspan grynspan added the enhancement New feature or request label Jan 11, 2025
@grynspan grynspan added this to the Swift 6.x milestone Jan 11, 2025
@grynspan grynspan self-assigned this Jan 11, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Windows

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Linux

@grynspan
Copy link
Contributor Author

@swift-ci test macOS

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test Linux

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

stmontgomery
stmontgomery reviewed Jan 13, 2025
View reviewed changes
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit c488632 into main Jan 13, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/remove-cxx-remnants branch January 13, 2025 19:52
@grynspan grynspan added the less-c++ 🐀 Work to reduce the size of our C++ codebase and/or dependencies label Jan 19, 2025
@grynspan grynspan added the discovery 🔎 test content discovery label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
discovery 🔎 test content discovery enhancement New feature or request less-c++ 🐀 Work to reduce the size of our C++ codebase and/or dependencies
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery