-
Notifications
You must be signed in to change notification settings - Fork 235
Add GH Action for CI #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add GH Action for CI #886
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b6f82cd
Add CI file
0xTim 5439124
Update CI to run site for testing
0xTim d9e7cea
add missing license headers
0xTim 4968068
Make soundness check pass
0xTim ef3ec8c
Run correct CI on the OpenAPI spec
0xTim e4a6672
Use Docker compose
0xTim 73680a4
Numptie
0xTim ed9c94b
Background and expose ports
0xTim 512d53d
Use local swift org
0xTim 4aeee4b
Remove download test for now
0xTim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
name: test | ||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
on: | ||
pull_request: { types: [opened, reopened, synchronize, ready_for_review] } | ||
push: { branches: [ main ] } | ||
|
||
jobs: | ||
soundness: | ||
name: Soundness Checks | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Run script | ||
run: ./scripts/soundness.sh | ||
|
||
build-site: | ||
name: Build the Jekyll Site | ||
runs-on: ubuntu-latest | ||
container: ruby:3.3 | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Build site | ||
run: bundle install && bundle exec jekyll build | ||
|
||
test-openapi: | ||
runs-on: ubuntu-latest | ||
container: swift:6.0 | ||
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
- name: Run OpenAPI Tester | ||
working-directory: openapi/TestSwiftOrgClient | ||
run: swift run |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to test that the JSON files backing the API actually still work, we'll need to start the jekyll server locally, and then tell the test CLI to fetch from that.
This might require installing Swift in the container based on the jekyll image, here in the pipeline. Or install jekyll into the Swift one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok. I've updated it so that we build the container and run that - also helps us test the container image is valid.
Since the default runner has Swift installed and Docker we shouldn't need to run it in a container