-
Notifications
You must be signed in to change notification settings - Fork 235
Add GH Action for CI #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Action for CI #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @0xTim! 🙏
steps: | ||
- name: Check out | ||
uses: actions/checkout@v4 | ||
- name: Run OpenAPI Tester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to test that the JSON files backing the API actually still work, we'll need to start the jekyll server locally, and then tell the test CLI to fetch from that.
This might require installing Swift in the container based on the jekyll image, here in the pipeline. Or install jekyll into the Swift one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok. I've updated it so that we build the container and run that - also helps us test the container image is valid.
Since the default runner has Swift installed and Docker we shouldn't need to run it in a container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
- name: Run OpenAPI Tester | ||
working-directory: openapi/TestSwiftOrgClient | ||
env: | ||
DOWNLOADSWIFTORG_SERVER_NAME: local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And SWIFTORG_SERVER_NAME=local is the other one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just beat you 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm you were faster and already did it 🫡
Not sure if the evolution API (downloads.swift.org) runs on the local jekyll server, actually. |
Ah yeah good point. Will remove that check for now |
@shahmishal can you remove the required mark for the old website build and switch it to the new one then merge? |
First steps for adopting GH actions with an action to run on PRs to make sure the site works. This runs:
jekyll build
@shahmishal can we can actions enabled? I don't know what the original CI was doing, I'm assuming just a Jekyll build