fix(isthmus): upgrade to Calcite 1.39.0 #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build shows a vulnerability scan failure, which originates from Calcite dependencies. Since this is currently the latest Calcite version available, it will have to wait for a new Calcite release to be resolved. |
|
The vulnerability in question is in https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5 Calcite 1.39 pulls in 5.4.1, but we should be able to bump it in our build to 5.4.4 which does not appear to have the vulnerability. We've done this before to deal with an vuln in Calcite 1.38 as well https://github.com/substrait-io/substrait-java/pull/329/files, and actually we should probably remove that workaround now. |
This version of Calcite improves support for nested window aggregation, which allows Isthmus to support several TPC-DS queries that were previously failing. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
calcite-1.39
branch
from
68076b6 to
f8232a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of Calcite improves support for nested window aggregation, which allows Isthmus to support several TPC-DS queries that were previously failing.