Skip to content

Commit 4d3640d

Browse files
feat(isthmus): upgrade to Calcite 1.39.0 (#393)
This version of Calcite improves support for nested window aggregation, which allows Isthmus to support several TPC-DS queries that were previously failing
1 parent 5bad4d4 commit 4d3640d

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ com.github.vlsi.vlsi-release-plugins.version=1.74
1515

1616
# library version
1717
antlr.version=4.13.1
18-
calcite.version=1.38.0
18+
calcite.version=1.39.0
1919
guava.version=32.1.3-jre
2020
immutables.version=2.10.1
2121
jackson.version=2.16.1

isthmus/build.gradle.kts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,13 @@ val PROTOBUF_VERSION = properties.get("protobuf.version")
8484
dependencies {
8585
api(project(":core"))
8686
api("org.apache.calcite:calcite-core:${CALCITE_VERSION}")
87-
// calcite-core 1.37.0 brings in net.minidev:json-smart:2.5.0 which has a CVE associated with it.
88-
// See: https://osv.dev/vulnerability/GHSA-pq2g-wx69-c263
89-
// This causes the build to fail. Pull in the fixed version until Calcite is updated
90-
implementation("net.minidev:json-smart:2.5.2")
87+
constraints {
88+
// calcite-core:1.39.0 has dependencies that contain vulnerabilities:
89+
// - CVE-2025-27820 (org.apache.httpcomponents.client5:httpclient5 < 5.4.3)
90+
// - CVE-2024-57699 (net.minidev:json-smart < 2.5.2)
91+
implementation("org.apache.httpcomponents.client5:httpclient5:5.4.4")
92+
implementation("net.minidev:json-smart:2.5.2")
93+
}
9194
implementation("org.apache.calcite:calcite-server:${CALCITE_VERSION}")
9295
testImplementation("org.junit.jupiter:junit-jupiter:${JUNIT_VERSION}")
9396
implementation("org.reflections:reflections:0.9.12")

isthmus/src/test/java/io/substrait/isthmus/TpcdsQueryNoValidation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
*/
3030
public class TpcdsQueryNoValidation extends PlanTestBase {
3131

32-
static final Set<Integer> EXCLUDED =
33-
Set.of(9, 12, 20, 27, 36, 47, 51, 53, 57, 63, 70, 86, 89, 98);
32+
static final Set<Integer> EXCLUDED = Set.of(9, 27, 36, 70, 86, 98);
3433

3534
static IntStream testCases() {
3635
return IntStream.rangeClosed(1, 99).filter(n -> !EXCLUDED.contains(n));

0 commit comments

Comments
 (0)