refactor: remove dependency on tree_height parameter on forest impl

[nimrod-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 63.27%. Comparing base (907b4d2) to head (b9ee89c).
Report is 2 commits behind head on main.

Files	Patch %	Lines
crates/committer/src/block_committer/commit.rs	0.00%	4 Missing ⚠️
crates/committer/src/block_committer/input.rs	0.00%	4 Missing ⚠️
...ter/src/patricia_merkle_tree/filled_tree/forest.rs	0.00%	1 Missing ⚠️
...kle_tree/original_skeleton_tree/skeleton_forest.rs	80.00%	0 Missing and 1 partial ⚠️
...rkle_tree/updated_skeleton_tree/skeleton_forest.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   61.69%   63.27%   +1.58%     
==========================================
  Files          36       36              
  Lines        1650     1702      +52     
  Branches     1650     1702      +52     
==========================================
+ Hits         1018     1077      +59     
+ Misses        583      575       -8     
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nimrod-starkware]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/types_test.rs line 38 at r1 (raw file):

#[case(15, NodeIndex::FIRST_LEAF + NodeIndex::from(15))]
#[case(0xDEADBEEF, NodeIndex::FIRST_LEAF + NodeIndex::from(0xDEADBEEF))]
fn test_cast_to_node_index(

The test has become quite redundant when the function doesn't depend on tree height; maybe it's better to remove it.

Code quote:

fn test_cast_to_node_index

[dorimedini-starkware]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/types_test.rs line 38 at r1 (raw file):

Previously, nimrod-starkware wrote…

The test has become quite redundant when the function doesn't depend on tree height; maybe it's better to remove it.

It checks conversions from contract address and storage key, so not completely redundant

---

crates/committer/src/patricia_merkle_tree/types_test.rs line 42 at r1 (raw file):

    #[case] expected_node_index: NodeIndex,
    #[values(true, false)] from_contract_address: bool,
) {

shorter, and means the same

Suggestion:

#[rstest]
fn test_cast_to_node_index(
    #[values(0, 15, 0xDEADBEEF)] leaf_index: u128,
    #[values(true, false)] from_contract_address: bool,
) {
    let expected_node_index = NodeIndex::FIRST_LEAF + leaf_index;

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/types_test.rs line 42 at r1 (raw file):

Previously, dorimedini-starkware wrote…

shorter, and means the same

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)