Skip to content

refactor: remove dependency on tree_height parameter on forest impl (… #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jun 3, 2024

#182)


This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Jun 3, 2024
@nimrod-starkware nimrod-starkware force-pushed the nimrod/fix_root_index branch from 8efc0e3 to d1b7b10 Compare June 3, 2024 10:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 62.13%. Comparing base (198f69e) to head (8efc0e3).
Report is 1 commits behind head on main.

Current head 8efc0e3 differs from pull request most recent head d1b7b10

Please upload reports for the commit d1b7b10 to get more accurate results.

Files Patch % Lines
crates/committer/src/block_committer/commit.rs 0.00% 4 Missing ⚠️
crates/committer/src/block_committer/input.rs 0.00% 4 Missing ⚠️
...patricia_merkle_tree/updated_skeleton_tree/tree.rs 0.00% 2 Missing ⚠️
...ter/src/patricia_merkle_tree/filled_tree/forest.rs 0.00% 1 Missing ⚠️
...kle_tree/original_skeleton_tree/skeleton_forest.rs 80.00% 0 Missing and 1 partial ⚠️
...rkle_tree/updated_skeleton_tree/skeleton_forest.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   61.74%   62.13%   +0.38%     
==========================================
  Files          36       36              
  Lines        1660     1624      -36     
  Branches     1660     1624      -36     
==========================================
- Hits         1025     1009      -16     
+ Misses        585      565      -20     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrod-starkware nimrod-starkware removed the request for review from TzahiTaub June 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants