Skip to content

fix: /v2/stackerdb metrics identifier typo #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: /v2/stackerdb metrics identifier typo #6296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stackslib/src/net/api/liststackerdbreplicas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ impl HttpRequest for RPCListStackerDBReplicasRequestHandler {
}

fn metrics_identifier(&self) -> &str {
"/v2/stackedb/:principal/:contract_name/replicas"
"/v2/stackerdb/:principal/:contract_name/replicas"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change of some sort that I should record in the Changelog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good question. It probably should be recorded in the Changelog, but am not sure if it is used anywhere that it would break anything internally. Externally...very possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - externally, it may break some metrics visualizations but i wouldn't think it would affect anything internally

}

/// Try to decode this request.
Expand Down
Loading