fix: /v2/stackerdb metrics identifier typo
#6296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
approved these changes
Jul 17, 2025
Jiloc
commented
Jul 18, 2025
| @@ -62,7 +62,7 @@ impl HttpRequest for RPCListStackerDBReplicasRequestHandler { | |||
| } | |||
|
|
|||
| fn metrics_identifier(&self) -> &str { | |||
| "/v2/stackedb/:principal/:contract_name/replicas" | |||
| "/v2/stackerdb/:principal/:contract_name/replicas" | |||
There was a problem hiding this comment.
Is this a breaking change of some sort that I should record in the Changelog?
There was a problem hiding this comment.
A good question. It probably should be recorded in the Changelog, but am not sure if it is used anywhere that it would break anything internally. Externally...very possible.
There was a problem hiding this comment.
agreed - externally, it may break some metrics visualizations but i wouldn't think it would affect anything internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I initially had this fix in #6201 but decided to move it a separate PR just in case.
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml