Skip to content

refactor(cli): add ConvertStringMapToInterfaceMap util function #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2025

Conversation

Benjosh95
Copy link
Contributor

@Benjosh95 Benjosh95 commented Jun 10, 2025

Description

Codebase contained multiple implementations of converting map[string]string to *map[string]interface{}. This pattern appears in many command files, particularly in the IaaS service commands (volume, backup, network, etc.) when handling label conversions. The code got extracted into util function ConvertStringMapToInterfaceMap and refactored.

Jira Ticket: https://jira.schwarz/browse/STACKITCLI-203

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

Copy link
Member

@rubenhoenle rubenhoenle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments from @marceljk

@rubenhoenle rubenhoenle added the needs-work PR needs work from author. label Jun 11, 2025
@Benjosh95 Benjosh95 force-pushed the refactor/cli-203-utility-func-map-conversion branch from 201509b to 1e76138 Compare June 11, 2025 16:03
@Benjosh95 Benjosh95 requested a review from rubenhoenle June 11, 2025 17:48
@Benjosh95 Benjosh95 removed the needs-work PR needs work from author. label Jun 11, 2025
marceljk
marceljk previously approved these changes Jun 12, 2025
Copy link
Contributor

@marceljk marceljk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! Can be merged

rubenhoenle
rubenhoenle previously approved these changes Jun 12, 2025
@Benjosh95 Benjosh95 dismissed stale reviews from rubenhoenle and marceljk via 456afb0 June 13, 2025 05:30
@rubenhoenle rubenhoenle merged commit 472ff26 into main Jun 13, 2025
3 of 4 checks passed
@rubenhoenle rubenhoenle deleted the refactor/cli-203-utility-func-map-conversion branch June 13, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants