-
Notifications
You must be signed in to change notification settings - Fork 17
refactor(cli): add ConvertStringMapToInterfaceMap util function #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rubenhoenle
merged 4 commits into
main
from
refactor/cli-203-utility-func-map-conversion
Jun 13, 2025
Merged
refactor(cli): add ConvertStringMapToInterfaceMap util function #790
rubenhoenle
merged 4 commits into
main
from
refactor/cli-203-utility-func-map-conversion
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceljk
reviewed
Jun 11, 2025
marceljk
reviewed
Jun 11, 2025
marceljk
reviewed
Jun 11, 2025
rubenhoenle
requested changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments from @marceljk
7 tasks
201509b
to
1e76138
Compare
marceljk
previously approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well! Can be merged
rubenhoenle
reviewed
Jun 12, 2025
rubenhoenle
previously approved these changes
Jun 12, 2025
rubenhoenle
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Codebase contained multiple implementations of converting
map[string]string
to*map[string]interface{}
. This pattern appears in many command files, particularly in the IaaS service commands (volume, backup, network, etc.) when handling label conversions. The code got extracted into util functionConvertStringMapToInterfaceMap
and refactored.Jira Ticket: https://jira.schwarz/browse/STACKITCLI-203
Checklist
make fmt
make generate-docs
(will be checked by CI)make test
(will be checked by CI)make lint
(will be checked by CI)