-
Notifications
You must be signed in to change notification settings - Fork 17
feat(cli): onboard iaas snapshot api #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Benjosh95
wants to merge
14
commits into
main
Choose a base branch
from
feat/onboard-iaas-snapshot-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check failing CI pipeline |
rubenhoenle
reviewed
Jun 6, 2025
rubenhoenle
reviewed
Jun 6, 2025
7 tasks
rubenhoenle
reviewed
Jun 11, 2025
rubenhoenle
reviewed
Jun 11, 2025
payload.Name = &testName | ||
|
||
// Convert test labels to map[string]interface{} | ||
labelsMap := map[string]interface{}{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- merge refactor(cli): add ConvertStringMapToInterfaceMap util function #790 first and use the new util func here
24d0562
to
72de161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onboarding the snapshot API https://docs.api.stackit.cloud/documentation/iaas/version/v1#tag/Snapshots to manage the snapshot resources via the cli.
Checklist
make fmt
make generate-docs
(will be checked by CI)make test
(will be checked by CI)make lint
(will be checked by CI)Testing-Instructions
Create a volume that will be used for snapshot testing.
stackit volume create
--availability-zone eu01-1
--size 10
--name "snapshot-test-vol"
--labels purpose=snapshot-testing
Create a snapshot of the volume above
volume-id
flagstackit volume snapshot create
--volume-id $VOLUME_ID
--name "test-snap-1"
--labels purpose=testing,test-type=minimal
List snapshot(s)
stackit volume snapshot list --limit 3
Describe snapshot
stackit volume snapshot describe $SNAPSHOT_ID
Update snapshot
stackit volume snapshot update $SNAPSHOT_ID
--name "test-snap-1-updated"
--labels purpose=testing-updated
Verify update
stackit volume snapshot describe $SNAPSHOT_ID
Delete the snapshot
stackit volume snapshot delete $SNAPSHOT_ID
Delete the volume
stackit volume delete $VOLUME_ID