-
-
Notifications
You must be signed in to change notification settings - Fork 8
Feat: Trino Listener Integration #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+736
−821
Merged
Changes from 23 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
6b917c7
add listener to roles
maltesander 1691220
wip - adapt role and rolegroup access
maltesander 2dcd4fc
remove unused error
maltesander f0f4c5e
fmt
maltesander 2dda23e
fix tests
maltesander 767e1c0
fmt
maltesander 7ca532c
regenerated charts
maltesander 6e607d8
add docs
maltesander f7a38d8
wip - working
maltesander ab6d4c9
make headless service name a function
maltesander 0f80bf3
added tests
maltesander 2ca405c
Merge branch 'main' into feat/trino-listener-integration
maltesander ecb48b5
adapted changelog
maltesander b36582d
move scripts to commons folder, fix tests
maltesander 6061ae9
new lines
maltesander 7d39acb
fix tls test
maltesander 09c7fb4
fix authentication test
maltesander 3d4e983
fix opa test
maltesander 0f8e2cb
attempt to fix
maltesander 5dd48d5
Merge branch 'main' into feat/trino-listener-integration
maltesander fcc2286
adapt getting started to listener
maltesander 0c24393
use role level listener
maltesander 4a90952
add lost comment
maltesander e9ce6e2
fix listener examples / comments
maltesander dd900e2
Apply suggestions from code review
maltesander b0c9874
Merge remote-tracking branch 'origin/main' into feat/trino-listener-i…
maltesander 01e86d1
clippy
maltesander dc397c1
fix smoke test
maltesander d3684d1
fix tls test
maltesander 665a4e7
fix authorization test
maltesander 186aa3f
regenerate charts
maltesander adb1a4e
Merge remote-tracking branch 'origin/main' into feat/trino-listener-i…
maltesander 5e3aa75
fix metrics test for lsitener changes
maltesander 1e22614
fix test
maltesander f44b8f8
Update rust/operator-binary/src/crd/mod.rs
maltesander ac5a5a5
Update rust/operator-binary/src/crd/mod.rs
maltesander 37bcd4f
fmt
maltesander 7921ba0
fix app version
maltesander e9669c2
Merge remote-tracking branch 'origin/main' into feat/trino-listener-i…
maltesander 2918423
remove merge artifact
maltesander 04953d8
adapt readme for smoke aws test
maltesander 4fd00f1
move rolegroup_metrics_service_name out of cluster impl
maltesander 186aa8e
typo
maltesander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,18 @@ | ||
= Service exposition with ListenerClasses | ||
:description: Configure Trino service exposure with ListenerClasses: cluster-internal, external-unstable, or external-stable. | ||
|
||
Trino offers a web UI and an API, both are exposed by the `connector` xref:concepts:roles-and-role-groups.adoc[role]. | ||
The Operator deploys a service called `<name>-connector` (where `<name>` is the name of the TrinoCluster) through which Trino can be reached. | ||
|
||
This service can have three different types: `cluster-internal`, `external-unstable` and `external-stable`. | ||
Read more about the types in the xref:concepts:service-exposition.adoc[service exposition] documentation at platform level. | ||
|
||
This is how the ListenerClass is configured: | ||
The operator deploys a xref:listener-operator:listener.adoc[Listener] for the coodinator pod. | ||
The listener defaults to only being accessible from within the Kubernetes cluster, but this can be changed by setting `.spec.coordinators.config.listenerClass`: | ||
|
||
[source,yaml] | ||
---- | ||
spec: | ||
clusterConfig: | ||
listenerClass: cluster-internal # <1> | ||
coordinators: | ||
config: | ||
listenerClass: external-unstable # <1> | ||
... | ||
workers: | ||
... | ||
---- | ||
<1> The default `cluster-internal` setting. | ||
<1> Specify a ListenerClass, such as `external-stable`, `external-unstable`, or `cluster-internal` (the default setting is `cluster-internal`). | ||
This can be set only for the coordinator role. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.