Skip to content

Feat: Trino Listener Integration #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jun 24, 2025
Merged

Feat: Trino Listener Integration #753

merged 43 commits into from
Jun 24, 2025

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jun 5, 2025 •
edited by adwk67
Loading

Description

fixes #700

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Jun 5, 2025
@maltesander maltesander marked this pull request as ready for review June 6, 2025 11:59
NickLarsenNZ
NickLarsenNZ reviewed Jun 18, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ reviewed Jun 18, 2025
View reviewed changes
NickLarsenNZ
NickLarsenNZ reviewed Jun 23, 2025
View reviewed changes
@maltesander @NickLarsenNZ
Update rust/operator-binary/src/crd/mod.rs
f44b8f8 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
NickLarsenNZ
NickLarsenNZ reviewed Jun 23, 2025
View reviewed changes
maltesander and others added 2 commits June 23, 2025 14:50
@maltesander @NickLarsenNZ
Update rust/operator-binary/src/crd/mod.rs
ac5a5a5 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@maltesander
fmt
37bcd4f
adwk67
adwk67 reviewed Jun 24, 2025
View reviewed changes
adwk67
adwk67 previously approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maltesander
Copy link
Member Author

https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/36/

@maltesander maltesander added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 129caf5 Jun 24, 2025
17 checks passed
@maltesander maltesander deleted the feat/trino-listener-integration branch June 24, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Trino Operator with Listener Operator
3 participants
@maltesander @adwk67 @NickLarsenNZ