Skip to content

chore: Update to operator-rs 0.77.1 and use new S3 structs #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 19, 2024

Description

Part of stackabletech/issues#640

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer self-assigned this Sep 19, 2024
@sbernauer
Copy link
Member Author

NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 19, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Sep 20, 2024
@razvan razvan removed this pull request from the merge queue due to a manual request Sep 20, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking this until stackabletech/operator-rs#871 is merged.

@sbernauer
Copy link
Member Author

@sbernauer sbernauer changed the title chore: Update to operator-rs 0.76.0 and use new S3 structs chore: Update to operator-rs 0.77.1 and use new S3 structs Sep 27, 2024
@sbernauer sbernauer requested review from Techassi and NickLarsenNZ and removed request for NickLarsenNZ and Techassi September 27, 2024 10:20
NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 27, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ
Copy link
Member

It could be worth a changelog entry

@sbernauer
Copy link
Member Author

Good catch, added in 285e805

@sbernauer sbernauer added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 2ac696e Sep 27, 2024
31 checks passed
@sbernauer sbernauer deleted the chore/new-s3-structs branch September 27, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants