-
-
Notifications
You must be signed in to change notification settings - Fork 4
test(omid): added omid kuttl test #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a complete review this time
@@ -0,0 +1,106 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the review of this file to @soenkeliebau, as it differs from the one our customer is using and I have no clue about omid.
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % actual omid Pod & config review
@sbernauer : had to update the test definition to not use the sandbox image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % actual omid Pod & config review
@razvan I'm a bit surprised you were able to merge this with unresolved conversations :O |
Looks like a comment doesn't count as conversation. I pinged him |
Interesting. Thanks! |
Description
Fixes stackabletech/issues#593
Depends on: stackabletech/docker-images#721
Successful kind run:
Definition of Done Checklist