Skip to content

test(omid): added omid kuttl test #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 20, 2024
Merged

test(omid): added omid kuttl test #515

merged 15 commits into from
Jun 20, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 17, 2024

Description

Fixes stackabletech/issues#593

Depends on: stackabletech/docker-images#721

Successful kind run:

$ ./scripts/run-tests --test-suite nightly --test omid
...
--- PASS: kuttl (167.48s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/omid_hbase-2.4.17_hdfs-3.3.6_zookeeper-3.8.4_openshift-false_omid-1.1.0,docker.stackable.tech_sandbox_omid_1.1.0-stackable0.0.0-dev (167.47s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs-style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan marked this pull request as ready for review June 18, 2024 09:22
@razvan razvan requested a review from a team June 18, 2024 09:22
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan
Copy link
Member Author

razvan commented Jun 18, 2024

@razvan razvan requested a review from sbernauer June 18, 2024 11:04
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a complete review this time

@@ -0,0 +1,106 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave the review of this file to @soenkeliebau, as it differs from the one our customer is using and I have no clue about omid.

razvan and others added 7 commits June 18, 2024 08:57
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan razvan requested review from soenkeliebau and sbernauer June 18, 2024 13:42
sbernauer
sbernauer previously approved these changes Jun 19, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % actual omid Pod & config review

@razvan
Copy link
Member Author

razvan commented Jun 19, 2024

@sbernauer : had to update the test definition to not use the sandbox image.

@razvan razvan requested a review from sbernauer June 19, 2024 10:18
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % actual omid Pod & config review

@razvan razvan added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 16f1dbe Jun 20, 2024
32 checks passed
@razvan razvan deleted the test/omid-2 branch June 20, 2024 06:42
@sbernauer
Copy link
Member

@razvan I'm a bit surprised you were able to merge this with unresolved conversations :O
Did @soenkeliebau get a chance to have a look a the omid Pod?

@razvan
Copy link
Member Author

razvan commented Jun 20, 2024

Looks like a comment doesn't count as conversation. I pinged him

@sbernauer
Copy link
Member

Interesting. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OMID integration tests
2 participants