Skip to content

feat(omid): include examples to simplify testing #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 17, 2024

Description

Required for: stackabletech/hbase-operator#515

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@lfrancke
Copy link
Member

What do these examples contain?

If they are "just" omid code we're probably fine but if they contain new dependencies etc. we should check with @dervoeti if they contain many new vulnerabilities.

@razvan razvan marked this pull request as ready for review June 18, 2024 09:20
@razvan razvan requested a review from a team June 18, 2024 09:21
@razvan
Copy link
Member Author

razvan commented Jun 18, 2024

What do these examples contain?

They have the same deps as the TSO server it's self : https://github.com/apache/phoenix-omid/blob/1.1.0/examples/pom.xml

@dervoeti
Copy link
Member

Yep, the numbers are the same:
image

I also checked some vulnerabilities in the examples and they were, as @razvan mentioned, already present in the TSO server.

Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit e0c1afb Jun 19, 2024
13 checks passed
@razvan razvan deleted the feat/omid-examples branch June 19, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants